Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fixit): remove redundant region tags #4124

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

briandorsey
Copy link
Member

Removed these tags:
run_tips_global_lazy
run_tips_global_scope
run_service_to_service_auth
run_secure_request
run_secure_request_do
run_system_package_handler
run_system_package_exec

Manually searched docs and confirmed no references remain.

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Removed these tags:
run_tips_global_lazy
run_tips_global_scope
run_service_to_service_auth
run_secure_request
run_secure_request_do
run_system_package_handler
run_system_package_exec

Manually searched docs and confirmed no references remain.
@briandorsey briandorsey requested review from a team as code owners May 7, 2024 18:52
Copy link

snippet-bot bot commented May 7, 2024

Here is the summary of changes.

You are about to delete 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 7, 2024
@briandorsey briandorsey requested a review from grayside May 7, 2024 18:55
@briandorsey briandorsey merged commit b45f484 into main May 7, 2024
11 checks passed
@briandorsey briandorsey deleted the fixit-tagcleanup-bd01 branch May 7, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants