Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Alphabet 10k sample dataset. #9337

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: Use Alphabet 10k sample dataset. #9337

merged 1 commit into from
May 23, 2024

Conversation

lee1premium
Copy link
Contributor

Use Alphabet 10k sample dataset.

Fixes: b/333583659

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@lee1premium lee1premium requested review from yoshi-approver and a team as code owners May 21, 2024 01:46
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels May 21, 2024
@lee1premium
Copy link
Contributor Author

Two unrelated errors are blocking this pull request:

  • aiplatform.CreateCustomJobSampleTest
  • aiplatform.CreateHyperparameterTuningJobSampleTest
[ERROR] aiplatform.CreateCustomJobSampleTest.testCreateCustomJobSample
[ERROR]   Run 1: CreateCustomJobSampleTest.testCreateCustomJobSample » InvalidArgument io.grpc....
[ERROR]   Run 2: CreateCustomJobSampleTest.tearDown:82 » NullPointer
[ERROR]   Run 3: CreateCustomJobSampleTest.testCreateCustomJobSample » InvalidArgument io.grpc....
[ERROR]   Run 4: CreateCustomJobSampleTest.tearDown:82 » NullPointer
[ERROR]   Run 5: CreateCustomJobSampleTest.testCreateCustomJobSample » InvalidArgument io.grpc....
[ERROR]   Run 6: CreateCustomJobSampleTest.tearDown:82 » NullPointer
[ERROR]   Run 7: CreateCustomJobSampleTest.testCreateCustomJobSample » InvalidArgument io.grpc....
[ERROR]   Run 8: CreateCustomJobSampleTest.tearDown:82 » NullPointer
[ERROR]   Run 9: CreateCustomJobSampleTest.testCreateCustomJobSample » InvalidArgument io.grpc....
[ERROR]   Run 10: CreateCustomJobSampleTest.tearDown:82 » NullPointer
[ERROR] aiplatform.CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample
[ERROR]   Run 1: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 2: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 3: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 4: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 5: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 6: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 7: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 8: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 9: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument
[ERROR]   Run 10: CreateHyperparameterTuningJobSampleTest.testCreateHyperparameterTuningJobSample » InvalidArgument

@Sita04
Copy link
Contributor

Sita04 commented May 23, 2024

@lee1premium Thanks for the sample. The associated issue is been looked into.

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2024
@Sita04 Sita04 merged commit 84fed3d into GoogleCloudPlatform:main May 23, 2024
8 checks passed
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@lee1premium @rafaelMurata
fix: Use Alphabet 10k sample dataset. (GoogleCloudPlatform#9337)
d0b24dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lee1premium @Sita04 @kokoro-team