Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compute route tests #10521

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

kotarsky
Copy link
Contributor

@kotarsky kotarsky commented Apr 24, 2024

adding new tests for compute.googleapis.com/Route

compute: added testes field to `compute.googleapis.com/Route` resource

Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from zli82016 April 24, 2024 17:23
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 24, 2024
@kotarsky
Copy link
Contributor Author

@zli82016 any tips related to this CLA error? I was wondering if this error should occur or not, because this is a public repository

@zli82016
Copy link
Member

zli82016 commented Apr 24, 2024

@zli82016 any tips related to this CLA error? I was wondering if this error should occur or not, because this is a public repository

Hello, @kotarsky , can you open this link https://github.com/GoogleCloudPlatform/magic-modules/pull/10521/checks?check_run_id=24214839145? Even this is a public repository, Contributor License Agreement (CLA) is required to sign.

@kotarsky
Copy link
Contributor Author

@zli82016 I can open this link.
While I try to sort this, I just wanted to confirm if what is in my commit is all I need to add the tests to the repository.

@zli82016
Copy link
Member

@zli82016 I can open this link. While I try to sort this, I just wanted to confirm if what is in my commit is all I need to add the tests to the repository.

Your commit is adding a test to tgc. Is it what you want to do?

Or is there a Github issue for this PR? If yes, can you please add it to the description section of this PR? Thanks.

@kotarsky
Copy link
Contributor Author

@zli82016 I can open this link. While I try to sort this, I just wanted to confirm if what is in my commit is all I need to add the tests to the repository.

Your commit is adding a test to tgc. Is it what you want to do?

Or is there a Github issue for this PR? If yes, can you please add it to the description section of this PR? Thanks.

There is no issue, it's just tests. But in this documentation it is saying that I should also include the tfplan.json file, but I couldn't find any file like that in the target folder, so I was wondering if the documentation is wrong or if I'm missing something.

@zli82016
Copy link
Member

@zli82016 I can open this link. While I try to sort this, I just wanted to confirm if what is in my commit is all I need to add the tests to the repository.

Your commit is adding a test to tgc. Is it what you want to do?
Or is there a Github issue for this PR? If yes, can you please add it to the description section of this PR? Thanks.

There is no issue, it's just tests. But in this documentation it is saying that I should also include the tfplan.json file, but I couldn't find any file like that in the target folder, so I was wondering if the documentation is wrong or if I'm missing something.

Sorry, the documentation is outdated. You don't need to include the _tfplan.json file.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 25, 2024
@zli82016
Copy link
Member

Created a Github issue to update the documentation. hashicorp/terraform-provider-google#17959

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 61 insertions(+))

add google_compute_route to resource_converters.go.erb file
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Apr 25, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 44 insertions(+))

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zli82016 zli82016 merged commit ed92bd3 into GoogleCloudPlatform:main Apr 25, 2024
11 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants