Add KMS support for the google_bigquery_connection resource

[daanheikens]

Fixes: hashicorp/terraform-provider-google#17955

Release Note Template for Downstream PRs (will be copied)

compute:  added the 'kms_key_name` field to the 'google_bigquery_connection` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 206 insertions(+))
google-beta provider: Diff ( 3 files changed, 206 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 162 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 12
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• bigqueryconnection

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

Hi! I'm taking over this review from Scott.

[daanheikens]

Hi! I'm taking over this review from Scott.

Hi! Thanks for the review, i will see too it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 178 insertions(+))
google-beta provider: Diff ( 3 files changed, 178 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 147 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 12
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• bigqueryconnection

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

Looks like the tests passed successfully! 🎉 Just a few small cleanups and it should be good to go.

[melinath]

This should be a full name since it's not a reference - projects/[kms_project_id]/locations/[region]/keyRings/[key_region]/cryptoKeys/[key]

[daanheikens]

Looked at the other example. Hope this works...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+))
google-beta provider: Diff ( 3 files changed, 156 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 138 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 13
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• bigqueryconnection

$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10561/artifacts/f3c38885-0912-4b71-88af-402e9ab3165c/build-log/replaying_test.log)

[melinath]

LGTM

stale review