Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make revoked access warning appear in red #5720

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

shuyama1
Copy link
Member

Co-authored-by: Alex smithyuk@users.noreply.github.com

Upstreams: hashicorp/terraform-provider-google#11090

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Co-authored-by: Alex <smithyuk@users.noreply.github.com>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@smithyuk
Copy link
Contributor

Hey, apologies I missed this - I've just signed the CLA. Thanks

@shuyama1 shuyama1 requested review from a team and rileykarson and removed request for a team March 10, 2022 19:56
@shuyama1 shuyama1 merged commit 93e7682 into GoogleCloudPlatform:main Mar 10, 2022
@shuyama1 shuyama1 deleted the upstream_11090_pr branch March 10, 2022 20:03
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
Co-authored-by: Alex <smithyuk@users.noreply.github.com>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
Co-authored-by: Alex <smithyuk@users.noreply.github.com>
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Co-authored-by: Alex <smithyuk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants