-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow node_pool and enable_autopilot together for custom service account and oauth scopes #6611
Allow node_pool and enable_autopilot together for custom service account and oauth scopes #6611
Conversation
This allows to specify custom service account and oauth scopes for Autopilot clusters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstance_soleTenantNodeAffinities |
Tests failed during RECORDING mode: Please fix these to complete your PR |
I did not touch any code related to this test. Maybe some accidental flake? I will sign CLA as soon as you confirm this PR might get merged eventually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestAccComputeInstance_soleTenantNodeAffinities is currently failing on all PRs; however, because container cluster and the related node resources are fairly complicated, you will definitely need to (at a minimum) add a test to make sure that the proposed config actually works.
I don't see any particular reason this wouldn't be merged at this time.
Sure, I will try to implement a test soon and come back.
Great, thanks! |
@@ -1064,8 +1066,7 @@ func resourceContainerCluster() *schema.Resource { | |||
Elem: &schema.Resource{ | |||
Schema: schemaNodePool, | |||
}, | |||
Description: `List of node pools associated with this cluster. See google_container_node_pool for schema. Warning: node pools defined inside a cluster can't be changed (or added/removed) after cluster creation without deleting and recreating the entire cluster. Unless you absolutely need the ability to say "these are the only node pools associated with this cluster", use the google_container_node_pool resource instead of this property.`, | |||
ConflictsWith: []string{"enable_autopilot"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really how we have to do this. The right field to use is cluster_autoscaling.auto_provisioning_defaults.service_account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fair enough. Closing this PR in the hopes of #6733 being merged eventually
As written above, closing this PR in the hopes of #6733 being merged eventually |
Reverts #4894 for
node_config
and implements workaround in a similar fashion forgoogle_container_cluster
node_pool
attributeFixes hashicorp/terraform-provider-google#9505
I was unable to run acceptance tests. As of current base commit, linter was only complaining about files I did not modify.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)