-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update datastream desired_state description #7636
base: main
Are you sure you want to change the base?
update datastream desired_state description #7636
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
20d5784
to
77cdac6
Compare
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
datastream documentation: Adding NOT_STARTED to the documentation options and explaining that PAUSED can only be used on running streams. ``` currently if you deploy with the PAUSED option set you will get the following error: │ Error: desired_state can only be set to NOT_STARTED or RUNNING when creating a new Stream The PAUSED option is only used for pausing currently running streams where the NOT_STARTED is used to deploy a stream without starting it.
77cdac6
to
166d713
Compare
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaserulesRelease_BasicRelease|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: All tests passed |
This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label |
This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label |
currently if you deploy with the PAUSED option set you will get the following error:
│ Error: desired_state can only be set to NOT_STARTED or RUNNING when creating a new Stream
The PAUSED option is only used for pausing currently running streams where the NOT_STARTED is used to deploy a stream without starting it.
provider pr here: hashicorp/terraform-provider-google#14212
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)