This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Add run-time and build-time configuration #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds information about which classes can be initialized at build-time and which should be initialized at run-time.
See: https://www.graalvm.org/reference-manual/native-image/ClassInitialization/
This information is used by Quarkus because it tries to initialize everything at build-time by default and needs the user to tell which ones can be initialized at run-time.
Included changes
I copied over
.propertiesconfigs from the Netty and put correct package names on them. This is needed becausegrpc-netty-shadeddoes not shade the classes referenced in the properties files. See context for doing this: Implement a working sample for Quarkus #30 (comment) This is a temporary measure; I filed an issue referenced in the link asking forgrpc-javato correctly shade the contents in the properties files too.Added a
.propertiesfile describing runtime/build-time classes forgrpc-netty-shaded. These are classes that reference native libraries; it seems like the native libraries must be linked at run-time to be safe, otherwise you get SEG FAULTS.