update untyped fixture

GoogleCloudPlatform · Apr 23, 2024 · 0f075c3 · 0f075c3
1 parent dfe917a
commit 0f075c3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 17 deletions.
diff --git a/exporter/collector/integrationtest/testcases/testcases_metrics.go b/exporter/collector/integrationtest/testcases/testcases_metrics.go
@@ -350,11 +350,7 @@ var MetricsTestCases = []TestCase{
 		Name:                 "[GMP] Untyped Gauge becomes a GCM Gauge and a Cumulative with /unknown and /unknown:counter suffixes",
 		OTLPInputFixturePath: "testdata/fixtures/metrics/untyped_gauge.json",
 		ExpectFixturePath:    "testdata/fixtures/metrics/untyped_gauge_gmp_expect.json",
-		ConfigureCollector: func(cfg *collector.Config) {
-			configureGMPCollector(cfg)
-			//nolint:errcheck
-			featuregate.GlobalRegistry().Set("gcp.untypedDoubleExport", true)
-		},
+		ConfigureCollector:   configureGMPCollector,
 		// prometheus_target is not supported by the SDK
 		SkipForSDK: true,
 	},

diff --git a/exporter/collector/integrationtest/testdata/fixtures/metrics/untyped_gauge.json b/exporter/collector/integrationtest/testdata/fixtures/metrics/untyped_gauge.json
@@ -38,20 +38,22 @@
                                     "value": {
                                        "stringValue": "13"
                                     }
-                                 },
-                                 {
-                                    "key": "prometheus.googleapis.com/internal/untyped_metric",
-                                    "value": {
-                                       "stringValue": "true"
-                                    }
                                  }
                               ],
                               "startTimeUnixNano": "1649443416286000000",
                               "timeUnixNano": "1649443516286000000",
                               "asDouble": 3
                            }
                         ]
-                     }
+                     },
+                     "metadata": [
+                        {
+                           "key": "prometheus.type",
+                           "value": {
+                              "stringValue": "unknown"
+                           }
+                        }
+                     ]
                   }
                ]
             }

diff --git a/exporter/collector/integrationtest/testdata/fixtures/metrics/untyped_gauge_expect.json b/exporter/collector/integrationtest/testdata/fixtures/metrics/untyped_gauge_expect.json
@@ -7,8 +7,7 @@
           "metric": {
             "type": "workload.googleapis.com/fake_untyped_metric",
             "labels": {
-              "ex_com_lemons_untyped": "13",
-              "prometheus_googleapis_com_internal_untyped_metric": "true"
+              "ex_com_lemons_untyped": "13"
             }
           },
           "resource": {
@@ -45,9 +44,6 @@
         "labels": [
           {
             "key": "ex_com_lemons_untyped"
-          },
-          {
-            "key": "prometheus_googleapis_com_internal_untyped_metric"
           }
         ],
         "metricKind": "GAUGE",