Include service attributes in logs exporter by default #564
+96
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
logs-service-labels
branch
from
f1e1f15
to
c29f620
Compare
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 64.16% 64.18% +0.02%
==========================================
Files 38 38
Lines 4216 4219 +3
==========================================
+ Hits 2705 2708 +3
Misses 1398 1398
Partials 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
(cc @jsuereth) |
damemi
force-pushed
the
logs-service-labels
branch
from
c29f620
to
399b4d0
Compare
|
Is this still a WIP? |
no, sorry. going with the labels for now and opened #565 to determine if that's our long-term solution or not |
dashpole
approved these changes
Jan 10, 2023
damemi
force-pushed
the
logs-service-labels
branch
from
399b4d0
to
3fdffda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the flow from metrics to include service resource attributes as LogEntry labels