Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth docs for Collector exporter #621

Merged
merged 1 commit into from Apr 7, 2023

Conversation

damemi
Copy link
Member

@damemi damemi commented Apr 7, 2023

Fixes #614
(for now)

This adds more detail around the different ways to authenticate the collector for GCP, de-emphasizing the use of gcloud auth application-default login and instead recommending the GCP service account.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #621 (e2c6426) into main (f50a6d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          36       36           
  Lines        4264     4264           
=======================================
  Hits         2825     2825           
  Misses       1312     1312           
  Partials      127      127           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@punya
Copy link
Contributor

punya commented Apr 7, 2023

Consider referencing https://cloud.google.com/docs/authentication/provide-credentials-adc as a canonical doc before summarizing the bits that are most relevant to our use case.

@damemi
Copy link
Member Author

damemi commented Apr 7, 2023

Consider referencing https://cloud.google.com/docs/authentication/provide-credentials-adc as a canonical doc before summarizing the bits that are most relevant to our use case.

sg, added a link at the top

@damemi damemi merged commit 3e802e2 into GoogleCloudPlatform:main Apr 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticating with gcloud auth login on GCE does not seem possible
2 participants