Fix GMP metric name handling #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 66.25% 66.25%
=======================================
Files 36 36
Lines 4264 4264
=======================================
Hits 2825 2825
Misses 1312 1312
Partials 127 127
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
reviewed
Apr 7, 2023
exporter/collector/integrationtest/testdata/fixtures/metrics/google_managed_prometheus.json
Show resolved
Hide resolved
aabmass
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OTLP metric data comes in with a URL-style metric name, the
googlemanagedprometheusexporter will sanitize the name but forget to prepend the correctprometheus.googleapis.com/prefix.