Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump genproto #693

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Bump genproto #693

merged 1 commit into from
Aug 2, 2023

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 2, 2023

Updates the genproto dependency to a version that carves out the api/rpc subpackages. In the future, this will allow dropping the dependency on the base genproto module altogether. See googleapis/go-genproto#1015 for details.

MODULE=google.golang.org/genproto VERSION=latest make update-dep
make gotidy
@liggitt liggitt requested a review from a team as a code owner August 2, 2023 17:00
@dashpole
Copy link
Contributor

dashpole commented Aug 2, 2023

/gcbrun

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #693 (35b2992) into main (54a8992) will decrease coverage by 0.17%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   69.31%   69.14%   -0.17%     
==========================================
  Files          36       36              
  Lines        4728     4728              
==========================================
- Hits         3277     3269       -8     
- Misses       1297     1305       +8     
  Partials      154      154              
Files Changed Coverage Δ
exporter/collector/logs.go 41.02% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole dashpole merged commit ce6e82d into GoogleCloudPlatform:main Aug 2, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants