Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BMS machines to the resource detection library #828

Merged
merged 5 commits into from Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 53 additions & 0 deletions detectors/gcp/bms.go
@@ -0,0 +1,53 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package gcp

const (
bmsProjectIDEnv = "BMS_PROJECT_ID"
bmsRegionEnv = "BMS_REGION"
bmsInstanceIDEnv = "BMS_INSTANCE_ID"
)

// Use BMS_PROJECT_ID, BMS_REGION and BMS_INSTANCE_ID env vars as an indication that we are running on BMS.
func (d *Detector) onBMS() bool {
alex-basinov marked this conversation as resolved.
Show resolved Hide resolved
projectID, projectIDExists := d.os.LookupEnv(bmsProjectIDEnv)
region, regionExists := d.os.LookupEnv(bmsRegionEnv)
instanceID, instanceIDExists := d.os.LookupEnv(bmsInstanceIDEnv)
return projectIDExists && regionExists && instanceIDExists && projectID != "" && region != "" && instanceID != ""
}

// BMSInstanceID returns the instance ID from the BMS_INSTANCE_ID environment variable.
func (d *Detector) BMSInstanceID() (string, error) {
if instanceID, found := d.os.LookupEnv(bmsInstanceIDEnv); found {
return instanceID, nil
}
return "", errEnvVarNotFound
}

// BMSCloudRegion returns the region from the BMS_REGION environment variable.
func (d *Detector) BMSCloudRegion() (string, error) {
if region, found := d.os.LookupEnv(bmsRegionEnv); found {
return region, nil
}
return "", errEnvVarNotFound
}

// BMSProjectID returns the project ID from the BMS_PROJECT_ID environment variable.
func (d *Detector) BMSProjectID() (string, error) {
if project, found := d.os.LookupEnv(bmsProjectIDEnv); found {
return project, nil
}
return "", errEnvVarNotFound
}
81 changes: 81 additions & 0 deletions detectors/gcp/bms_test.go
@@ -0,0 +1,81 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package gcp

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestBMSInstanceID(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{
bmsInstanceIDEnv: "my-host-123",
},
})
instanceID, err := d.BMSInstanceID()
assert.NoError(t, err)
assert.Equal(t, instanceID, "my-host-123")
}

func TestBMSInstanceIDErr(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{},
})
instanceID, err := d.BMSInstanceID()
assert.Error(t, err)
assert.Equal(t, instanceID, "")
}

func TestBMSBMSCloudRegion(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{
bmsRegionEnv: "us-central1",
},
})
region, err := d.BMSCloudRegion()
assert.NoError(t, err)
assert.Equal(t, region, "us-central1")
}

func TestBMSCloudRegionErr(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{},
})
region, err := d.BMSCloudRegion()
assert.Error(t, err)
assert.Equal(t, region, "")
}

func TestBMSBMSProjectID(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{
bmsProjectIDEnv: "my-test-project",
},
})
projectID, err := d.BMSProjectID()
assert.NoError(t, err)
assert.Equal(t, projectID, "my-test-project")
}

func TestBMSProjectIDErr(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{},
})
projectID, err := d.BMSProjectID()
assert.Error(t, err)
assert.Equal(t, projectID, "")
}
3 changes: 3 additions & 0 deletions detectors/gcp/detector.go
Expand Up @@ -40,11 +40,14 @@ const (
CloudFunctions
AppEngineStandard
AppEngineFlex
BMS
)

// CloudPlatform returns the platform on which this program is running.
func (d *Detector) CloudPlatform() Platform {
switch {
case d.onBMS():
return BMS
case d.onGKE():
return GKE
case d.onCloudFunctions():
Expand Down
12 changes: 12 additions & 0 deletions detectors/gcp/detector_test.go
Expand Up @@ -90,6 +90,18 @@ func TestCloudPlatformCloudFunctions(t *testing.T) {
assert.Equal(t, platform, CloudFunctions)
}

func TestCloudPlatformBMS(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{}, &FakeOSProvider{
Vars: map[string]string{
bmsInstanceIDEnv: "foo",
bmsProjectIDEnv: "bar",
bmsRegionEnv: "qux",
},
})
platform := d.CloudPlatform()
assert.Equal(t, platform, BMS)
}

func TestProjectID(t *testing.T) {
d := NewTestDetector(&FakeMetadataProvider{
Project: "my-project",
Expand Down