fix: flatten ValueTypeSlice to ValueTypeString #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Apr 12, 2024
|
Thanks for finding this @crossk3! |
|
@dashpole updated to use |
|
/gcbrun |
dashpole
reviewed
Apr 23, 2024
Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: Keaton Cross <keatoncross6@gmail.com>
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
==========================================
+ Coverage 61.03% 62.30% +1.26%
==========================================
Files 56 56
Lines 5903 4892 -1011
==========================================
- Hits 3603 3048 -555
+ Misses 2143 1687 -456
Partials 157 157 ☔ View full report in Codecov by Sentry. |
|
Ah, you will need to run |
@dashpole done! |
dashpole
approved these changes
Apr 23, 2024
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
While working with the OpenTelemetry stack for Python as well as an OpenTelemetry Collector (Cloud Run Sidecar, per docs here), I noticed a discrepancy in behavior.
GCP Cloud Trace doesn't support Slice/Array data types for Trace Attributes, which Python's
CloudTraceSpanExporterhandles by flattening Slices to Strings. However, the golang Collector Exporter currently silently drops anySlice[T]attribute. This results in some oddities when choosing how to send traces to GCP Cloud Trace, where any time a collector exports to GCP Cloud Trace you silently lose attributes you would otherwise receive in Cloud Trace.This PR attempts to unify this behavior, so that the same behavior is observed whether using the in-process exporter or the googlecloud Collector exporter.