Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CreateServiceTimeSeries #837

Merged
merged 4 commits into from Apr 22, 2024

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Apr 19, 2024

Adds support for CreateServiceTimeSeries

Testing

  • go test ./...

FIxes #820

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.11%. Comparing base (4caace7) to head (d84c4ae).
Report is 4 commits behind head on main.

Files Patch % Lines
exporter/metric/metric.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   61.03%   62.11%   +1.07%     
==========================================
  Files          56       56              
  Lines        5903     4859    -1044     
==========================================
- Hits         3603     3018     -585     
+ Misses       2143     1684     -459     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psx95 psx95 marked this pull request as ready for review April 19, 2024 22:20
@psx95 psx95 requested a review from a team as a code owner April 19, 2024 22:20
@psx95 psx95 merged commit 88c799a into GoogleCloudPlatform:main Apr 22, 2024
32 checks passed
@psx95 psx95 deleted the support-service-timeseries branch April 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for createservicetimeseries to the SDK metrics exporter
2 participants