Deduplicate target_info and scope_info #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
approved these changes
Apr 23, 2024
damemi
approved these changes
Apr 23, 2024
dashpole
force-pushed
the
dedup_extra_metrics
branch
from
dd4ab14
to
4698662
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 61.03% 62.29% +1.25%
==========================================
Files 56 56
Lines 5903 4890 -1013
==========================================
- Hits 3603 3046 -557
+ Misses 2143 1687 -456
Partials 157 157 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #834
It ensures there is only one target_info for each unique combination of service.* resource attributes. This ensures that GMP metrics can always be joined with target_info on job + instance.
It ensures there is only one otel_scope_info for each scope name + version within a resource.