Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storagecontrol): Adding new library sample #1989

Merged
merged 1 commit into from Apr 30, 2024

Conversation

vishwarajanand
Copy link
Member

Fixes googleapis/google-cloud-php#7243

Storagecontrol Library already created googleapis/google-cloud-php#7245

Tests pass on prod:

➜  storagecontrol git:(feat_storage_control) ✗ ../testing/vendor/bin/phpunit -c phpunit.xml.dist
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Warning:       XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set

.                                                                   1 / 1 (100%)

Time: 00:03.340, Memory: 10.00 MB

OK (1 test, 2 assertions)
➜  storagecontrol git:(feat_storage_control) ✗

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 30, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review April 30, 2024 08:59
@vishwarajanand vishwarajanand requested a review from a team as a code owner April 30, 2024 08:59
Copy link

snippet-bot bot commented Apr 30, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@vishwarajanand vishwarajanand merged commit 1625b80 into main Apr 30, 2024
13 checks passed
@vishwarajanand vishwarajanand deleted the feat_storage_control branch April 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: Support Storage Control Quickstart
2 participants