chore: Add Cloud Spanner OC client metrics sample #6515
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #6514, adds a sample for capturing Cloud Spanner gRPC metrics with OpenCensus.
Note that we need to do extra work to instrument gRPC to emit the stats we're collecting here. We may want to wait to merge this PR or include this in public docs until we make the required gRPC changes.
FYI @larkee you're the owner of
/spanner/**/*.py
in CODEOWNERS, let me know if you want me to add a separate entry for OC samples and make myself the owner.cc @mayurkale22
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)These samples need a new API enabled in testing projects to pass (let us know which ones)These samples need a new/updated env vars in testing projects set to pass (let us know which ones)This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample