Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use renamed create_feature_view() function in optimized notebook #2944

Merged
merged 1 commit into from
May 16, 2024

Conversation

mrkumar9001
Copy link
Collaborator

Fx colab parameter usage - the linting/auto-format placed some variables across multiple lines which doesn't work in colab. Also fix some usage for getting FOS - this can be done directly using SDK constructor.

REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.


Uses updated SDK function. Fixes colab forms that nbfmt auto-format broke.


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.

Not relevant

  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@mrkumar9001 mrkumar9001 requested a review from a team as a code owner May 6, 2024 20:13
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mrkumar9001
Copy link
Collaborator Author

Note: This does NOT pass lint due to nbfmt wanting to place the FEATURE_ONLINE_STORE_ID variable across multiple lines - however, this breaks colab forms https://colab.research.google.com/notebooks/forms.ipynb. Any guidance?

@gericdong
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

/gcbrun

@mrkumar9001 mrkumar9001 force-pushed the mine/optimized branch 2 times, most recently from 73966f7 to df07db3 Compare May 8, 2024 21:45
Copy link

@felipeliliti felipeliliti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7

@mrkumar9001 mrkumar9001 force-pushed the mine/optimized branch 3 times, most recently from 3fbed79 to ece3f1b Compare May 14, 2024 16:57
Fx colab parameter usage - the linting/auto-format placed some variables
across multiple lines which doesn't work in colab. Make the FOS ID names
shorter to avoid this issue.

Also fix some usage for getting FOS - this can be done directly using
SDK constructor.

Set PSC allow list project to current project.

Increase sleep for DNS propagation to pass CI.
@gericdong gericdong added this pull request to the merge queue May 16, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 9fed51d May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants