Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEPLOY_SOURCE to all MG notebooks. #2947

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

dstnluong-google
Copy link
Contributor

@dstnluong-google dstnluong-google commented May 8, 2024

Add DEPLOY_SOURCE to all MG notebooks.


--- YOUR PR SUMMARY GOES HERE ---


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

Copy link

google-cla bot commented May 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dstnluong-google dstnluong-google force-pushed the model_garden_629577775 branch 11 times, most recently from 34461d8 to 240460a Compare May 8, 2024 04:30
@dstnluong-google dstnluong-google changed the title Sync GitHub repo Add DEPLOY_SOURCE to all MG notebooks. May 8, 2024
@dstnluong-google dstnluong-google marked this pull request as ready for review May 8, 2024 15:52
@dstnluong-google dstnluong-google requested a review from a team as a code owner May 8, 2024 15:52
@gericdong gericdong added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 44d11be May 8, 2024
8 checks passed
@felipeliliti
Copy link

repositório GoogleCloudPlatform/vertex-ai-samples contém exemplos de código e notebooks para o Vertex AI, que é uma plataforma de aprendizado de máquina de ponta a ponta no Google Cloud2. A adição de DEPLOY_SOURCE a todos os notebooks MG provavelmente está relacionada à configuração ou otimização do processo de implantação desses notebooks.

@dstnluong-google dstnluong-google deleted the model_garden_629577775 branch May 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants