"fix: resolve issue where cache layers would be pushed if --no-push w…

…as specified" (#3132)
GoogleContainerTools · May 14, 2024 · d65b9b5 · d65b9b5
1 parent 0da9ed0
commit d65b9b5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/executor/push.go b/pkg/executor/push.go
@@ -398,8 +398,8 @@ func pushLayerToCache(opts *config.KanikoOptions, cacheKey string, tarPath strin
 		return errors.Wrap(err, "appending layer onto empty image")
 	}
 	cacheOpts := *opts
-	cacheOpts.TarPath = ""   // tarPath doesn't make sense for Docker layers
-	cacheOpts.NoPush = false // we want to push cached layers
+	cacheOpts.TarPath = ""         // tarPath doesn't make sense for Docker layers
+	cacheOpts.NoPush = opts.NoPush // we don't want to push cached layers if no push is specified
 	cacheOpts.Destinations = []string{cache}
 	cacheOpts.InsecureRegistries = opts.InsecureRegistries
 	cacheOpts.SkipTLSVerifyRegistries = opts.SkipTLSVerifyRegistries