Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: verify should preserve job manifest envs #9087

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Sep 11, 2023

Fixes: #8974

  • To use container information provided from user's k8s job manifest, we cannot just replace the container with the one set up in skaffold.yaml
  • We can use the container in the job manifest as the base, apply a patch with verify container.
  • Note that to make the patch work, the container names must match in skaffold.yaml verify stanza and from k8s job manifest.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #9087 (2c45989) into main (290280e) will decrease coverage by 7.16%.
Report is 1024 commits behind head on main.
The diff coverage is 49.90%.

@@            Coverage Diff             @@
##             main    #9087      +/-   ##
==========================================
- Coverage   70.48%   63.32%   -7.16%     
==========================================
  Files         515      626     +111     
  Lines       23150    32204    +9054     
==========================================
+ Hits        16317    20394    +4077     
- Misses       5776    10264    +4488     
- Partials     1057     1546     +489     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 430 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review September 11, 2023 18:12
@ericzzzzzzz ericzzzzzzz merged commit 6297a7c into GoogleContainerTools:main Sep 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold verify ignores container environment variables on local minikube cluster
2 participants