Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change bazel example #9218

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Dec 12, 2023

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (e28625e) 63.67%.
Report is 1077 commits behind head on main.

❗ Current head e28625e differs from pull request most recent head e2ac47f. Consider uploading reports for the commit e2ac47f to get more accurate results

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9218      +/-   ##
==========================================
- Coverage   70.48%   63.67%   -6.82%     
==========================================
  Files         515      632     +117     
  Lines       23150    32545    +9395     
==========================================
+ Hits        16317    20722    +4405     
- Misses       5776    10232    +4456     
- Partials     1057     1591     +534     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review December 12, 2023 17:36
@ar3s3ru
Copy link
Contributor

ar3s3ru commented Dec 12, 2023

@ericzzzzzzz @renzodavid9 would it also make sense to remove this limitation on the target name? It was mostly due to rules_docker convention if I'm not mistaken:

if !strings.HasSuffix(a.BuildTarget, ".tar") {
return "", errors.New("the bazel build target should end with .tar, see https://github.com/bazelbuild/rules_docker#using-with-docker-locally")
}

@ericzzzzzzz
Copy link
Contributor Author

@ar3s3ru agree to remove the validation.

@ericzzzzzzz ericzzzzzzz merged commit f2323ea into GoogleContainerTools:main Dec 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants