Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extracted kaniko copyTimeout and copyMaxRetries into config #9267

Merged

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Jan 19, 2024

Description
I use skaffold for big project and sometimes it takes more than 5 minutes to create tar(it tries to add more than 80k files) and fails because of timeout, but 5m was hardcoded so I decided to extract it to config.

Changes previews
image

@idsulik idsulik requested a review from a team as a code owner January 19, 2024 16:11
@idsulik
Copy link
Contributor Author

idsulik commented Jan 20, 2024

Hi!
Should I do anything else or I just need to wait?

@idsulik
Copy link
Contributor Author

idsulik commented Jan 30, 2024

@MarlonGamez , hi! Could you please review the PR? The size is big because of generated files(2 new config keys for kaniko), the changes themselves aren't that big.
I have to build skaffold with increased kaniko timeout for my colleagues because the default timeout of 5m is too low for us, it'll be convenient to use specify timeout in the config file

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (fa9df48) 63.55%.
Report is 1103 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9267      +/-   ##
==========================================
- Coverage   70.48%   63.55%   -6.94%     
==========================================
  Files         515      634     +119     
  Lines       23150    32721    +9571     
==========================================
+ Hits        16317    20795    +4478     
- Misses       5776    10322    +4546     
- Partials     1057     1604     +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz merged commit 6ea9aeb into GoogleContainerTools:main Jan 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants