Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate schema v4beta9 #9287

Merged

Conversation

renzodavid9
Copy link
Contributor

Related: #9236

Description
New schema version to support GCB repositories v2 as a remote dependency option

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (4ff8979) 63.55%.
Report is 1102 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9287      +/-   ##
==========================================
- Coverage   70.48%   63.55%   -6.93%     
==========================================
  Files         515      634     +119     
  Lines       23150    32709    +9559     
==========================================
+ Hits        16317    20788    +4471     
- Misses       5776    10317    +4541     
- Partials     1057     1604     +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renzodavid9 renzodavid9 marked this pull request as ready for review January 30, 2024 18:15
@renzodavid9 renzodavid9 requested a review from a team as a code owner January 30, 2024 18:15
@renzodavid9 renzodavid9 requested review from gsquared94 and ericzzzzzzz and removed request for gsquared94 January 30, 2024 18:15
@renzodavid9 renzodavid9 merged commit 7b30538 into GoogleContainerTools:main Jan 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants