Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating google api and opentelemetry version #9352

Merged
merged 1 commit into from Mar 21, 2024

Conversation

bskaplan
Copy link
Contributor

Description

Update the Google Cloud API Client and OpenTelemetry to the latest versions.

User facing changes (remove if N/A)

The latest Cloud Run features will now be supported, notably built-in support for mounting gcsfuse and NFS volumes. See https://cloud.google.com/run/docs/configuring/services/cloud-storage-volume-mounts#yaml and https://cloud.google.com/run/docs/configuring/services/nfs-volume-mounts#yaml for example YAMLs.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 63.58%. Comparing base (290280e) to head (96ea662).
Report is 1118 commits behind head on main.

Files Patch % Lines
pkg/skaffold/instrumentation/export.go 82.60% 4 Missing ⚠️
pkg/skaffold/instrumentation/firelog/exporter.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9352      +/-   ##
==========================================
- Coverage   70.48%   63.58%   -6.91%     
==========================================
  Files         515      635     +120     
  Lines       23150    32790    +9640     
==========================================
+ Hits        16317    20848    +4531     
- Misses       5776    10334    +4558     
- Partials     1057     1608     +551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Mar 21, 2024
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 21, 2024
@ericzzzzzzz ericzzzzzzz merged commit ba3ee3f into GoogleContainerTools:main Mar 21, 2024
15 checks passed
@idsulik
Copy link
Contributor

idsulik commented Apr 14, 2024

@bskaplan hi! why you added fs/assets/credits_generated/github.com/hashicorp/hcl/go.mod? Any go command changes this file now according to this golang/go#34842.
image

@bskaplan
Copy link
Contributor Author

I didn't have any particular reason. I was updating the dependent modules, I guess that file got picked up when I updated them and I was mostly focused on making sure everything still worked with the updates. If that file isn't necessary, you can send another PR deleting it.

@idsulik
Copy link
Contributor

idsulik commented Apr 17, 2024

@bskaplan have you deleted the line by yourself? because golang adds this line by itself whenever you use any go command.
@ericzzzzzzz , what do you think about this #9352 (comment) ? should we delete the go.mod file or should we specify go version there?

@ericzzzzzzz
Copy link
Contributor

Hi @idsulik, I think we may have to keep this file. The file was auto-generated by go-license, go-license is supposed to just extract LICENSES from dependencies of skaffold without other files, but somehow it also includes this file. We have license check in our ci which also compares the output from go-license run on our ci and the generated_credits folder from pr branch, if there is discrepancy, ci will fail. Although it's a little annoying, it doesn't affect skaffold functionalities.

@idsulik
Copy link
Contributor

idsulik commented Apr 17, 2024

@ericzzzzzzz Thank you for the details, added the go version here https://github.com/GoogleContainerTools/skaffold/pull/9390/files#diff-8939f41b03be02a3877b5d557f6b6adb21c33906b5c3093f6e7f626ed9f07044R3 , otherwise go cli updates it automatically and you see changed file, so you have to manually exclude it from commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants