chore: bump moby/buildkit and opencontainers/runc versions, upgrade go to 1.22 #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verAdress' is intentionally propagated to resolve a bug and was introduced in docker/cli@b24e7f8
…n a bool to match the ErrNotFound interace in github.com/docker/docker/errdefs/defs.go
alphanota
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9364 +/- ##
==========================================
- Coverage 70.48% 63.19% -7.30%
==========================================
Files 515 642 +127
Lines 23150 32983 +9833
==========================================
+ Hits 16317 20842 +4525
- Misses 5776 10531 +4755
- Partials 1057 1610 +553 ☔ View full report in Codecov by Sentry. |
alphanota
changed the title
ericzzzzzzz
approved these changes
Mar 28, 2024
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9288, #9357, #9358
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
goconstandnakedretrules for go code style check are disabled at this moment, it seems the new golang-lint version has made those rules more rigid and they're blocking ci, we'll fix that in another issuecoverageredesignis disabled withGOEXPERIMENT=nocoverageredesignwhen running test coverage job due to a bug in go 1.22.1, which error out folder doesn't have tests and it's blocking ci. This is already been fixed in the go code base, we will for another go 1.22 release to turn on this.User facing changes (remove if N/A)
Follow-up Work (remove if N/A)
Most likely bump up the versions of other dependencies if they exist.