Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests to inline text formatting #1612

Closed
12 tasks done
barklund opened this issue May 6, 2020 · 0 comments · Fixed by #2718
Closed
12 tasks done

Add integration tests to inline text formatting #1612

barklund opened this issue May 6, 2020 · 0 comments · Fixed by #2718
Assignees
Labels
Elements: Text Needs Tests P1 High priority, must do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️

Comments

@barklund
Copy link
Contributor

barklund commented May 6, 2020

Feature Description

Inline text formatting is in dire need of exhaustive integration testing, that can validate all the different possible interactions, including but not limited to:

In edit-mode: Inline collapsed selection

A.k.a. inline style override, works with bold, italic and underline only:

In edit-mode: Inline non-collapsed selection

To be checked with single style and multi style selection:

  • check that design panel correctly reflects current selection
  • check that boolean toggles (bold, italic and underline) work by shortcut and design panel
  • check that selecting font weight, letter spacing or font color correctly styles selection
  • check that non-inline properties still applies to entire text field even though inline selection exists

Not in edit-mode: Single text field selection

All to be checked with single style and multiple styles present:

Not in edit-mode: Multiple text field selection

All to be checked with single style and multiple styles present between text fields:


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@barklund barklund added the P1 High priority, must do soon label May 19, 2020
@barklund barklund added this to the Sprint 31 milestone Jun 10, 2020
@barklund barklund self-assigned this Jun 19, 2020
@barklund barklund added the Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ label Jun 22, 2020
@bmattb bmattb modified the milestones: Sprint 31, Sprint 32 Jun 29, 2020
@bmattb bmattb modified the milestones: Sprint 32, Sprint 33 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Text Needs Tests P1 High priority, must do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants