Added integration tests for inline text formatting #2718

barklund · 2020-06-25T05:02:52Z

Summary

This PR implements the tests listed in #1612.

Relevant Technical Choices

Adds new DOM selectors and accessors to karma container structure - including some new generic components
Abstracts common functionality in _utils.js file.

To-do

See #1612

User-facing changes

None

Testing Instructions

None, if tests pass, we're good!

Fixes #1612

codecov · 2020-06-25T05:05:11Z

Codecov Report

Merging #2718 into master will increase coverage by 15.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2718       +/-   ##
===========================================
+ Coverage   67.34%   82.38%   +15.03%     
===========================================
  Files         729      740       +11     
  Lines       12360    12465      +105     
===========================================
+ Hits         8324    10269     +1945     
+ Misses       4036     2196     -1840

Flag	Coverage Δ
#karmatests	`65.48% <100.00%> (?)`
#unittests	`65.98% <100.00%> (+0.02%)`	⬆️

Impacted Files	Coverage Δ
...sets/src/edit-story/components/canvas/editLayer.js	`100.00% <ø> (+86.36%)`	⬆️
...rc/edit-story/components/panels/textStyle/color.js	`63.63% <ø> (ø)`
...ry/components/richText/useSelectionManipulation.js	`100.00% <ø> (+100.00%)`	⬆️
...sets/src/edit-story/components/form/color/color.js	`100.00% <100.00%> (ø)`
...edit-story/components/inspector/inspectorLayout.js	`100.00% <100.00%> (+62.50%)`	⬆️
...ts/src/edit-story/components/panels/panel/panel.js	`69.38% <100.00%> (+3.47%)`	⬆️
...edit-story/components/panels/panel/shared/title.js	`78.12% <100.00%> (+3.93%)`	⬆️
...ory/components/inspector/document/publish/index.js	`82.35% <0.00%> (-5.15%)`	⬇️
assets/src/edit-story/elements/text/output.js	`96.87% <0.00%> (ø)`
assets/src/edit-story/utils/textMeasurements.js	`72.09% <0.00%> (ø)`
... and 195 more

barklund · 2020-06-25T05:05:31Z

assets/src/edit-story/components/panels/panel/shared/title.js

  } = useContext(panelContext);
  const {
    state: { inspectorContentHeight },
  } = useInspector();

+  useEffect(confirmTitle, [confirmTitle]);


Not all panels have a title ("No selection" panel in particular), and if a panel doesn't have a title but still has aria-labelledby referencing a non-existent id, AXE e2e tests start failing as it's an illegal WAI-ARIA property.

This is not the prettiest way to do it, but it works.

github-actions · 2020-06-25T05:07:12Z

Size Change: +422 B (0%)

Total Size: 1.06 MB

Filename	Size	Change
`assets/js/edit-story.js`	462 kB	+242 B (0%)
`assets/js/stories-dashboard.js`	526 kB	+180 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`assets/css/edit-story.css`	269 B	0 B
`assets/css/stories-dashboard.css`	305 B	0 B
`assets/css/web-stories-embed-block.css`	515 B	0 B
`assets/js/web-stories-activation-notice.js`	55.8 kB	0 B
`assets/js/web-stories-embed-block.js`	16.4 kB	0 B

_{compressed-size-action}

dvoytenko

This looks very good, imho. Just a few nits.

assets/src/edit-story/components/richText/karma/_utils.js

assets/src/edit-story/karma/fixture/containers/canvas.js

assets/src/edit-story/karma/fixture/containers/common/select.js

dvoytenko

LGTM with one request

# Conflicts: # assets/src/edit-story/karma/fixture/containers/editor.js

assets/src/edit-story/karma/fixture/containers/designPanel/textStyle.js

assets/src/edit-story/components/form/color/color.js

miina

This is awesome!!!

Added some questions/comments.

assets/src/edit-story/components/richText/karma/singleSelection.karma.js

assets/src/edit-story/components/richText/karma/multiSelection.karma.js

assets/src/edit-story/components/richText/karma/inlineStyleOverride.karma.js

Co-authored-by: Pascal Birchler <pascalb@google.com>

…ries-wp into test/1612-itf-integration

assets/src/edit-story/components/richText/karma/inlineSelection.karma.js

miina

LGTM!

swissspidy · 2020-07-09T13:39:41Z

@barklund ready to merge?

dvoytenko

Approved. One general ask: please add a few snapshots in CUJ tests.

assets/src/edit-story/components/richText/karma/inlineStyleOverride.karma.js

assets/src/edit-story/components/richText/karma/multiSelection.karma.js

Morten Barklund added 3 commits June 24, 2020 19:01

WIP karma tests for rich text

f14b2fc

Merge branch 'master' into test/1612-itf-integration

5f7549b

Implemented tests for inline style override

55b552f

barklund added this to the Sprint 31 milestone Jun 25, 2020

barklund requested a review from dvoytenko June 25, 2020 05:02

barklund self-assigned this Jun 25, 2020

googlebot added the cla: yes label Jun 25, 2020

barklund commented Jun 25, 2020

View reviewed changes

Added waiting before assuming font weight has been properly selected

57ade82

dvoytenko suggested changes Jun 25, 2020

View reviewed changes

Various updates from review

59e09b6

dvoytenko approved these changes Jun 25, 2020

View reviewed changes

swissspidy added Skip Changelog Type: Enhancement New feature or improvement of an existing feature labels Jun 26, 2020

Morten Barklund added 5 commits June 26, 2020 17:53

Added inline selection tests

2aaee5a

Added integration tests for single element selection of text field

be1aa44

Added multi-selection ITF tests

b1c4c41

Merge branch 'master' into test/1612-itf-integration

03138b9

# Conflicts: # assets/src/edit-story/karma/fixture/containers/editor.js

Added todo for missing items

a9c4da2

barklund marked this pull request as ready for review June 27, 2020 03:26

barklund requested review from dvoytenko, swissspidy and miina June 27, 2020 03:26

Renamed variable

1306a7e

barklund changed the title ~~[WIP] Added integration tests for inline text formatting~~ Added integration tests for inline text formatting Jun 29, 2020

miina reviewed Jun 30, 2020

View reviewed changes

assets/src/edit-story/karma/fixture/containers/designPanel/textStyle.js Outdated Show resolved Hide resolved

swissspidy reviewed Jun 30, 2020

View reviewed changes

assets/src/edit-story/components/form/color/color.js Outdated Show resolved Hide resolved

miina reviewed Jun 30, 2020

View reviewed changes

Morten Barklund and others added 7 commits June 30, 2020 13:08

Update assets/src/edit-story/components/form/color/color.js

740e554

Co-authored-by: Pascal Birchler <pascalb@google.com>

Merge branch 'master' into test/1612-itf-integration

0ef750c

Merge branch 'test/1612-itf-integration' of github.com:google/web-sto…

31832a7

…ries-wp into test/1612-itf-integration

remove unused (and soon outdated) font picker reference

c3647b8

Update comments and moved a few things around

c9da0ae

Add extra test case

716485b

Fixed some tests that suddenly act differently

05f9256

barklund requested a review from miina July 1, 2020 22:35

Removed irrelevant wait

16c450e

miina reviewed Jul 6, 2020

View reviewed changes

assets/src/edit-story/components/richText/karma/inlineSelection.karma.js Outdated Show resolved Hide resolved

miina approved these changes Jul 6, 2020

View reviewed changes

Minor test comment update

2a867db

swissspidy removed this from the Sprint 31 milestone Jul 9, 2020

dvoytenko approved these changes Jul 10, 2020

View reviewed changes

assets/src/edit-story/components/richText/karma/inlineStyleOverride.karma.js Show resolved Hide resolved

assets/src/edit-story/components/richText/karma/multiSelection.karma.js Show resolved Hide resolved

Morten Barklund added 2 commits July 13, 2020 18:56

Added snapshot for karma test results

2904881

Merge branch 'master' into test/1612-itf-integration

b757968

barklund merged commit cc37fd1 into master Jul 14, 2020

barklund deleted the test/1612-itf-integration branch July 14, 2020 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added integration tests for inline text formatting #2718

Added integration tests for inline text formatting #2718

barklund commented Jun 25, 2020

codecov bot commented Jun 25, 2020 •

edited

barklund Jun 25, 2020

github-actions bot commented Jun 25, 2020 •

edited

dvoytenko left a comment

dvoytenko left a comment

miina left a comment

miina left a comment

swissspidy commented Jul 9, 2020

dvoytenko left a comment

Added integration tests for inline text formatting #2718

Added integration tests for inline text formatting #2718

Conversation

barklund commented Jun 25, 2020

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

codecov bot commented Jun 25, 2020 • edited

Codecov Report

barklund Jun 25, 2020

Choose a reason for hiding this comment

github-actions bot commented Jun 25, 2020 • edited

dvoytenko left a comment

Choose a reason for hiding this comment

dvoytenko left a comment

Choose a reason for hiding this comment

miina left a comment

Choose a reason for hiding this comment

miina left a comment

Choose a reason for hiding this comment

swissspidy commented Jul 9, 2020

dvoytenko left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 25, 2020 •

edited

github-actions bot commented Jun 25, 2020 •

edited