Update to Jest 28 #11387
Merged
Update to Jest 28 #11387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
swissspidy
force-pushed
the
add/10843-jest-v28
branch
from
ccb993e
to
e124e4e
Compare
swissspidy
force-pushed
the
add/10843-jest-v28
branch
from
e124e4e
to
5e44f06
Compare
# Conflicts: # package-lock.json
|
Size Change: 0 B Total Size: 2.61 MB ℹ️ View Unchanged
|
|
Plugin builds for efbe101 are ready 🛎️!
|
timarney
reviewed
May 18, 2022
packages/story-editor/src/components/checklist/countContext/test/checkCountContext.js
Show resolved
Hide resolved
timarney
previously approved these changes
May 18, 2022
# Conflicts: # package-lock.json # package.json # packages/dashboard/package.json # packages/story-editor/package.json
Comment on lines
+57
to
61
| await page.waitForFunction( | ||
| () => | ||
| wp.data.select('core/editor').getEditedPostAttribute('status') === | ||
| 'publish' | ||
| ); |
There was a problem hiding this comment.
Can you give some more details here?
There was a problem hiding this comment.
Previously this util just checked for wp.data.select('core/editor').getPermalink() and that it doesn't return null. If it returns a truthy value (e.g. the permalink string), we assumed the post was published.
But apparently nowadays wp.data.select('core/editor').getPermalink() always returns a string with the permalink, even if the post is still a draft.
We now wait for the post status to actually change and for the "View Post" link to appear, so that we are more certain that the post was actually published.
spacedmonkey
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jest v28 has built-in support for sharding.
Summary
Updates Jest to v28 and follows the upgrade guide to update the test configuration.
Relevant Technical Choices
jest-parallell-sequencerpackageexportsresolver workarounds for two packages with known incompatibilities@wordpress/jest-consolefrom JS unit tests, as this more meant for e2e test contextChecklistCategoryProvidertest to spy onconsole.errorto keep the logs cleanTo-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #10843