Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several npm dependencies #13612

Closed
wants to merge 9 commits into from
Closed

Update several npm dependencies #13612

wants to merge 9 commits into from

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Mar 27, 2024

Summary

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Mar 27, 2024

This comment was marked as resolved.

@googleforcreators-bot

This comment was marked as resolved.

@swissspidy

This comment was marked as resolved.

@swissspidy swissspidy marked this pull request as draft March 27, 2024 16:46
@swissspidy
Copy link
Collaborator Author

All e2e tests involving non-admin users are failing. I'm a bit at loss as why this happens.

Looking at the artifacts, they seem to be stuck at the very beginning when trying to create a new story and typing the story title:

Quick-Edit-should-save-story-without-breaking-markup-2024-03-28T09-02-35

As if none of the toClick() or page.type() would work, but then why are they working for other users...?

Maybe there are some console errors that aren't being logged?

To reproduce:


# Build plugin
DISABLE_PREVENT=true DISABLE_QUICK_TIPS=true npm run build

# Spin up Docker environment
npm run env:start

# Run all tests...
npm run test:e2e

# or just a specific one...
npm run test:e2e packages/e2e-tests/src/specs/wordpress/quickEdit.js

# Or with headless disabled so you can see what's going on
PUPPETEER_HEADLESS=false npm run test:e2e

@AnuragVasanwala @Swanand01 maybe you have some ideas off the top of your head? Does npm run test:e2e packages/e2e-tests/src/specs/wordpress/quickEdit.js fail for you on this branch?

@AnuragVasanwala
Copy link
Collaborator

Does npm run test:e2e packages/e2e-tests/src/specs/wordpress/quickEdit.js fail for you on this branch?

Yes, it does fail for us on this branch.

@AnuragVasanwala @Swanand01 maybe you have some ideas off the top of your head?

We are trying to figure out what went wrong!

@swissspidy
Copy link
Collaborator Author

Closing this in favor of updating stuff individually, that will be easier to do.

@swissspidy swissspidy closed this May 15, 2024
@swissspidy swissspidy deleted the chore/deps branch May 15, 2024 12:05
@swissspidy swissspidy mentioned this pull request May 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants