Added plain text paste handler #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barklund
added
Elements: Text
Pod: Prometheus (Workspace)
Group: Copy/Paste
|
Size Change: +461 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
miina
approved these changes
Sep 21, 2020
Codecov Report
@@ Coverage Diff @@
## main #4600 +/- ##
===========================================
+ Coverage 70.10% 83.34% +13.24%
===========================================
Files 881 882 +1
Lines 15519 15530 +11
===========================================
+ Hits 10880 12944 +2064
+ Misses 4639 2586 -2053
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I don't think we can test with native paste event for this, but I can try. |
|
@barklund would an e2e test be possible? If so, happy to help |
|
Testing this is not easy (in Puppeteer/Playwright/Cypress/Selenium), I had the best luck (consistency across browsers/oss) with something like this: const plainText = "Foo Bar";
const pasteEvent = Object.assign(
new Event("paste", { bubbles: true, cancelable: true }),
{
clipboardData: {
types: ["text/plain"],
items: {
length: 1,
0: {
kind: "string",
type: "text/plain",
getAsString: () => plainText
}
},
getData: (type) => plainText
}
}
);
document.activeElement.dispatchEvent(pasteEvent); |
swissspidy
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Custom handling of pasted (plain text) content.
Note that this ignores formatted content. That work is still pending in #760.
Testing Instructions
NB: Note that rich text formatting is ignored in pasted content. The content is pasted to match the style of the text field, not the original formatting from where it was pasted.
Fixes #1605