Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and restore last target when accessing the page again #5

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Save and restore last target when accessing the page again #5

merged 1 commit into from
Mar 23, 2023

Conversation

s-rigaud
Copy link
Contributor

Hi 馃憢
First of all, thanks ! Your project saved me a lot of hours for personal projects 馃槃

I think it might be a good feature to keep the target saved between two access to the page. For example, I mainly use your website to generate Pydantic models and I don't care about the others. It would be nice to have it set to Pydantic each time 馃槂

I just updated the tsx file, you still need to build the project and to publish it. I hope you will implement this feature soon !

@Gowee Gowee merged commit 5eea765 into Gowee:main Mar 23, 2023
@Gowee
Copy link
Owner

Gowee commented Mar 23, 2023

Hi, s-rigaud.

To make the target in the URL hash still relevant, I tweak the code slightly: caf78fa

These should allow restoring the target from the URL hash in addition to localStorage. I have tested on Chrome/Firefox, to find the URL without hash always takes higher priority in the address bar. So they should work like a charm without interfering with each other. In case there is still any issue around this in other cases, please let me know.

Thanks for your contribution!

@Gowee
Copy link
Owner

Gowee commented Mar 23, 2023

The new build of Web app appears to be blocked by rustwasm/wasm-pack#1248. Hopefully to be resolved soon.

@s-rigaud
Copy link
Contributor Author

Can't you downgrade to a previous version to build the website ?

@Gowee
Copy link
Owner

Gowee commented Mar 23, 2023

It is an external dep that is out of the control of the lock file. I just tweaked the build script on pages.dev as a temporary fix. Now the new build has been deployed: https://github.com/Gowee/json2pyi/runs/12218782428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants