Add Area and Centroid nodes #1749
Conversation
0HyperCube
force-pushed
the
create-area-and-centroid-nodes
branch
from
3e4f70c
to
c2cb287
Compare
elbertronnie
force-pushed
the
create-area-and-centroid-nodes
branch
from
9f2cfc4
to
2671107
Compare
Keavon
force-pushed
the
create-area-and-centroid-nodes
branch
2 times, most recently
from
ab7adc3
to
67467f0
Compare
Keavon
force-pushed
the
create-area-and-centroid-nodes
branch
from
67467f0
to
64b6bb2
Compare
|
!build |
| @@ -218,6 +218,20 @@ impl Bezier { | |||
|
|
|||
| self.get_points().all(|point| point.abs_diff_eq(start, MAX_ABSOLUTE_DIFFERENCE)) | |||
| } | |||
|
|
|||
| // TODO: What about the case when a handle extends beyond the start or end point? Is that considered "equivalent to a line"? | |||
There was a problem hiding this comment.
I added this TODO comment. Can you please resolve this by mentioning the appropriate thing here to document this edge case? Thanks!
There was a problem hiding this comment.
The is_linear will function will declare it as a line and that is what we want. The problem is in the place is_linear will be used. The start and end points will be chosen incorrectly. Instead it should use the handle point if it is further than start or end points.
There was a problem hiding this comment.
Actually this was originally put because the pen tool uses cubic beziers for straight lines. The handle are exactly at the same position of start and end. Since its actual use-case was covered. I did not think any further. If we want it to work for all cases then I will require some time think about it.
|
|
!build |
|
|
Cool! capture_29_.mp4 |
perimeter_centroidforBezierandSubpaththat calculates the line integral of position.is_linearwhich check if the bezier curve is equivalent to a line. Used in the calculation of intersection of two bezier curves where initially a line-like cubic bezier would give the wrong area.