Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.26.0 #18615

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2024

Bumps com.google.protobuf:protobuf-bom from 3.25.3 to 4.26.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.3 to 4.26.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-bom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file maven labels Mar 14, 2024
@thll thll self-assigned this Mar 14, 2024
@thll
Copy link
Contributor

thll commented Mar 14, 2024

We are using gRPC in depending projects. grpc-java does not work with protobuf 4.26 yet, so we have to wait for a new release > v1.62.2

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 28, 2024

A newer version of com.google.protobuf:protobuf-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@thll
Copy link
Contributor

thll commented Apr 25, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 25, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@thll
Copy link
Contributor

thll commented Apr 30, 2024

@dependabot ignore this major version

@dependabot dependabot bot closed this Apr 30, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 30, 2024

OK, I won't notify you about version 4.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/maven/com.google.protobuf-protobuf-bom-4.26.0 branch April 30, 2024 07:20
@thll
Copy link
Contributor

thll commented Apr 30, 2024

We can't move to protobuf version 4.x yet. See grpc/grpc-java#11015 and protocolbuffers/protobuf#16452.

@thll
Copy link
Contributor

thll commented Apr 30, 2024

@dependabot show com.google.protobuf:protobuf-bom ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 30, 2024

Ignore Conditions
Dependency Ignore Condition
com.google.protobuf:protobuf-bom [>= 4.a, < 5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant