Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Netty arm64 dependencies #19245

Merged
merged 6 commits into from May 13, 2024
Merged

add Netty arm64 dependencies #19245

merged 6 commits into from May 13, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented May 5, 2024 •
edited by bernd

Description

add Netty arm64 dependencies (aarch_64)

/nocl

Motivation and Context

improve compatibility with ARM 64 systems

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented May 5, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@sullis
Copy link
Contributor Author

sullis commented May 6, 2024

Ready for review

bernd
bernd requested changes May 8, 2024
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! One small comment below.

graylog2-server/src/test/java/org/graylog2/NettyTest.java Show resolved Hide resolved
@bernd bernd self-assigned this May 8, 2024
@sullis
Copy link
Contributor Author

sullis commented May 8, 2024

workflows awaiting approval

bernd
bernd approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@bernd bernd merged commit a0668cc into Graylog2:master May 13, 2024
4 of 6 checks passed
@sullis sullis deleted the sean/netty-arm64 branch May 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd approved these changes

Assignees

@bernd bernd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sullis @CLAassistant @bernd