Small refactoring for SegmentedControl component.
#19291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
refactor/segmented-control
branch
from
e1ab7f0
to
64ee704
Compare
grotlue
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This PR is required for https://github.com/Graylog2/graylog-plugin-enterprise/pull/7240
Description
Motivation and Context
This PR contains a small refactoring for the
SegmentedControlcomponent. We are:handleChangeprop toonChangeto follow our naming convention and we are simplifying the related type.aswhen providing theonChangefunctionArray<string>for thedataprop. It is being supported by the mantineSegmentedControlcomponent, but having a look at theSelectcomponent, future maintenance will be easier if we allow only one format for these options./nocl