Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units stored in search type metrics #19307

Merged
merged 3 commits into from May 17, 2024
Merged

Units stored in search type metrics #19307

merged 3 commits into from May 17, 2024

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented May 9, 2024 •
edited

Description

The change is present in 0508db0 commit, put on top of not-yet-merged PR #19138

Selected metrics can now reference units.
Fixes #19308
/nocl

Motivation and Context

Needed by FE.

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@luk-kaminski luk-kaminski changed the title Units/units stored in search type metrics Units stored in search type metrics May 9, 2024
@luk-kaminski luk-kaminski force-pushed the units/units_stored_in_search_type_metrics branch from 8d993a2 to 0508db0 Compare May 10, 2024 09:19
@dennisoelkers dennisoelkers force-pushed the units/units_stored_in_search_type_metrics branch from 0f14757 to 23115da Compare May 17, 2024 07:12
@janheise janheise marked this pull request as ready for review May 17, 2024 09:34
@dennisoelkers dennisoelkers merged commit 3749a79 into master May 17, 2024
5 checks passed
@dennisoelkers dennisoelkers deleted the units/units_stored_in_search_type_metrics branch May 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisoelkers dennisoelkers dennisoelkers approved these changes

@janheise janheise janheise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend chosen Search Types with unit reference
3 participants
@luk-kaminski @dennisoelkers @janheise