Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new updates #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mohamed-ehab51
Copy link
Contributor

there were some functions that requires "press ENTER" to continue running and they interrupt the GUI in the background so I added the "ENTER" in the script to stepover this problem

and updated the requirements file with python-magic-bin instead of python-magic

and keep pillow==9.5 because it's the last compatible release till now

@mohamed-ehab51
Copy link
Contributor Author

some questions:
1- didn't thought about making release? it's easier to install for the normal users
2- why do you keep some tools buttons in the GUI and never implement their functionality .... delete them, or at least make them unclickable, I thought there is a problem with the packages and the code, but when I read the code to know why they aren't working I found out that they don't have a code :) and they just return in the if statement.
3-the multiple compression tool has code already and I guess it's working (didn't dive deep in the statistics to verify them) but it makes output, so I suppose it's working .... but you commented it, why?

I didn't alter any of those in the commit, I am just asking about your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant