Add feature flag linux-tmpfs to list tmpfs mounts
#1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ apple-app-store = ["apple-sandbox"] | |||
| c-interface = [] | |||
| multithread = ["rayon"] | |||
| linux-netdevs = [] | |||
| linux-tmpfs = [] | |||
There was a problem hiding this comment.
Is it useful to separate each filtered out file type or can they be all put under the same feature like "linu-extra-fs"?
There was a problem hiding this comment.
That would work for me, although the caveat about hangs with network filesystems might be restrictive for other people. So I'm unsure - either way is fine by me though.
There was a problem hiding this comment.
It's a good point, let's keep them split.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition as I needed to get stats on a tmpfs mount which is filtered out currently.
Let me know if there's anything that needs changing or if I've missed any limitations that resulted in tmpfs mounts being filtered in the first place