Use OsString for Process Args and Env Vars
#1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues the "os stringification" on the `Process` type where now not only the process name, but also the arguments and environment variables are also done as `OsString`, mirroring `std`.
| @@ -661,7 +662,7 @@ fn get_all_pid_entries( | |||
| if !entry.is_dir() { | |||
| return None; | |||
| } | |||
| let pid = Pid::from(usize::from_str(&name.to_string_lossy()).ok()?); | |||
| let pid = Pid::from(usize::from_str(name.to_str()?).ok()?); | |||
There was a problem hiding this comment.
Why not use to_str_lossy here?
There was a problem hiding this comment.
For lossiness, the Unicode replacement character (�) is used, but that never results in a validly parsed usize, so might as well skip directly to returning an error, instead of allocating and then erroring anyway.
There was a problem hiding this comment.
True. Thanks for the explanations!
|
Just one question but otherwise changes look good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the "os stringification" on the
Processtype where now not only the process name, but also the arguments and environment variables are also done asOsString, mirroringstd.