fix: remove use of from_utf8_unchecked in macos process handling
#1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those unsafe functions have been observed to not respect their safety constraints, as some values retrieved from the macos API are not guaranteed to be UTF-8. This is fixed by replacing those calls with `from_utf8_lossy`, which will replace those values with a replacement character to ensure the generated String is valid. This solution is not ideal, but the master branch contains the better fix: an OsString is returned to let the caller decide how to handle the value. Changing those calls remove the need of unsafe blocks, so those were removed at the same time.
GuillaumeGomez
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those unsafe functions have been observed to not respect their safety constraints, as some values retrieved from the macos API are not guaranteed to be UTF-8.
This is fixed by replacing those calls with
from_utf8_lossy, which will replace those values with a replacement character to ensure the generated String is valid.This solution is not ideal, but the master branch contains the better fix: an OsString is returned to let the caller decide how to handle the value.
Changing those calls remove the need of unsafe blocks, so those were removed at the same time.
Fixes #1256