hoist out timebase_to_ns in process interval calculation to fix CPU usage calculation #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
approved these changes
Mar 24, 2023
|
Thanks a lot for this fix! I'll make a new release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be one way to fix the issue highlighted in #956 due to
timebase_to_nsdiffering between ARM and x86. From my experience, this has effectively no effect on x86 sincetimebase_to_nsis normally just 1 on that platform.Tested on my M1 Macbook Pro and an x86 macOS emulator to both be close to
htopwhen used to compileprocess-viewer.