Upgrade NPM to v7 #2086
Merged
Upgrade NPM to v7 #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 that we use (and even node 14) includes npm 6.
However npm prompts you to upgrade, which I suspect most people do (or at least I have!). The
package-lock,jsonfile format changes in npm 7 and, as that is checked in, it leads to a changed file after running 'npm install'.Annoyingly it seems you cannot upgrade npm separately and after a few attempts I figured it's easier to just go to node v15 (which includes npm v7) in our actions. Note there is no need to go beyond node v12 locally (with npm 7) as we don't use anything (other than npm) which is different between the two.