Fix #4456: Add shift+pageUp key and shift+pageDown key navigation in Calendar component #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key Add shift+pageUp and shift+pageDown handlers aligned with W3C WAI-ARIA principles. Previously navigation moves to the previous month and the next month instead of moving to one year before and after. After this change, it's moving to [the previous and the next year](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/) Closes Hacker0x01#4456
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4457 +/- ##
=======================================
Coverage 95.46% 95.47%
=======================================
Files 29 29
Lines 2513 2518 +5
Branches 1026 1032 +6
=======================================
+ Hits 2399 2404 +5
Misses 114 114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This is a single-purpose change that matches the description and has appropriate unit tests. There are no issues noted in the updates.
Reviewed with ❤️ by PullRequest
Brooooooklyn
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jan 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [Hacker0x01/react-datepicker#4393 #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [Hacker0x01/react-datepicker#4421 - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4432 - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4430 - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4438 - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4394 - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [Hacker0x01/react-datepicker#4437 - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4457 - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4469 #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [Hacker0x01/react-datepicker#4421 - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [Hacker0x01/react-datepicker#4393 - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [Hacker0x01/react-datepicker#4437 - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [Hacker0x01/react-datepicker#4469 **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [Hacker0x01/react-datepicker#4405 - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [Hacker0x01/react-datepicker#4391 - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4417 #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [Hacker0x01/react-datepicker#4405 - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [Hacker0x01/react-datepicker#4391 **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [Hacker0x01/react-datepicker#4384 - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [Hacker0x01/react-datepicker#4373 - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [Hacker0x01/react-datepicker#4392 #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [Hacker0x01/react-datepicker#4384 - [@​shimech](https://togithub.com/shimech) made their first contribution in [Hacker0x01/react-datepicker#4373 - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [Hacker0x01/react-datepicker#4392 **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
Brooooooklyn
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jan 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [Hacker0x01/react-datepicker#4393 #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [Hacker0x01/react-datepicker#4421 - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4432 - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4430 - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4438 - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4394 - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [Hacker0x01/react-datepicker#4437 - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4457 - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4469 #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [Hacker0x01/react-datepicker#4421 - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [Hacker0x01/react-datepicker#4393 - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [Hacker0x01/react-datepicker#4437 - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [Hacker0x01/react-datepicker#4469 **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [Hacker0x01/react-datepicker#4405 - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [Hacker0x01/react-datepicker#4391 - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4417 #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [Hacker0x01/react-datepicker#4405 - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [Hacker0x01/react-datepicker#4391 **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [Hacker0x01/react-datepicker#4384 - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [Hacker0x01/react-datepicker#4373 - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [Hacker0x01/react-datepicker#4392 #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [Hacker0x01/react-datepicker#4384 - [@​shimech](https://togithub.com/shimech) made their first contribution in [Hacker0x01/react-datepicker#4373 - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [Hacker0x01/react-datepicker#4392 **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
Brooooooklyn
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Feb 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [Hacker0x01/react-datepicker#4393 #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [Hacker0x01/react-datepicker#4421 - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4432 - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4430 - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4438 - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4394 - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [Hacker0x01/react-datepicker#4437 - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4457 - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4469 #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [Hacker0x01/react-datepicker#4421 - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [Hacker0x01/react-datepicker#4393 - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [Hacker0x01/react-datepicker#4437 - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [Hacker0x01/react-datepicker#4469 **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [Hacker0x01/react-datepicker#4405 - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [Hacker0x01/react-datepicker#4391 - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4417 #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [Hacker0x01/react-datepicker#4405 - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [Hacker0x01/react-datepicker#4391 **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [Hacker0x01/react-datepicker#4384 - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [Hacker0x01/react-datepicker#4373 - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [Hacker0x01/react-datepicker#4392 #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [Hacker0x01/react-datepicker#4384 - [@​shimech](https://togithub.com/shimech) made their first contribution in [Hacker0x01/react-datepicker#4373 - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [Hacker0x01/react-datepicker#4392 **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
Brooooooklyn
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Feb 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [Hacker0x01/react-datepicker#4393 #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [Hacker0x01/react-datepicker#4421 - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4432 - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4430 - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4438 - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4394 - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [Hacker0x01/react-datepicker#4437 - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4457 - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4469 #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [Hacker0x01/react-datepicker#4421 - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [Hacker0x01/react-datepicker#4393 - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [Hacker0x01/react-datepicker#4437 - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [Hacker0x01/react-datepicker#4469 **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [Hacker0x01/react-datepicker#4405 - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [Hacker0x01/react-datepicker#4391 - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4417 #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [Hacker0x01/react-datepicker#4405 - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [Hacker0x01/react-datepicker#4391 **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [Hacker0x01/react-datepicker#4384 - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [Hacker0x01/react-datepicker#4373 - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [Hacker0x01/react-datepicker#4392 #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [Hacker0x01/react-datepicker#4384 - [@​shimech](https://togithub.com/shimech) made their first contribution in [Hacker0x01/react-datepicker#4373 - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [Hacker0x01/react-datepicker#4392 **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
fkoulen
added a commit
to ASVGay/the-rhapsodies
that referenced
this pull request
Feb 17, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.14.0` -> `^6.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.25.0/6.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react-datepicker](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-datepicker) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-datepicker)) | [`^4.11.2` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@types%2freact-datepicker/4.19.6/6.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v6.1.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v6.1.0): 6.1.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v6.0.0...v6.1.0) #### What's Changed - Fix - Removed defaultProps from Function Components for React 18.3. by [@​shyk001](https://togithub.com/shyk001) in [Hacker0x01/react-datepicker#4498 #### New Contributors - [@​shyk001](https://togithub.com/shyk001) made their first contribution in [Hacker0x01/react-datepicker#4498 **Full Changelog**: Hacker0x01/react-datepicker@v6.0.0...v6.1.0 ### [`v6.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v6.0.0): 6.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.1.0...v6.0.0) #### What's Changed - Upgrade date-fns to v3 by [@​ethanve](https://togithub.com/ethanve) in [Hacker0x01/react-datepicker#4481 - Switch workflows to Node 20 by [@​martijnrusschen](https://togithub.com/martijnrusschen) in [Hacker0x01/react-datepicker#4490 #### New Contributors - [@​ethanve](https://togithub.com/ethanve) made their first contribution in [Hacker0x01/react-datepicker#4481 **Full Changelog**: Hacker0x01/react-datepicker@v5.1.0...v6.0.0 ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.1.0): 5.1.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) #### What's Changed - Fix options passed to date-fns/parse by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4474 **Full Changelog**: Hacker0x01/react-datepicker@v5.0.0...v5.1.0 ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [Hacker0x01/react-datepicker#4393 #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [Hacker0x01/react-datepicker#4421 - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4432 - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4430 - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4438 - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4394 - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [Hacker0x01/react-datepicker#4437 - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [Hacker0x01/react-datepicker#4457 - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [Hacker0x01/react-datepicker#4469 #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [Hacker0x01/react-datepicker#4421 - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [Hacker0x01/react-datepicker#4393 - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [Hacker0x01/react-datepicker#4437 - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [Hacker0x01/react-datepicker#4469 **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ASVGay/the-rhapsodies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4456
Description
This PR addresses the navigation behavior in the calendar component to enhance accessibility based on W3C WAI-ARIA principles. Previously, the shift+pageUp and shift+pageDown key handers navigated one month before and after the selected date (which is the handler for the pageUp and pageDown), which could be confusing for users. The update modifies the behavior to move to the previous and the next year, providing a more intuitive and accessible experience.
Reference Link
Changes Made
Related issues
Closes #4456