This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
[SERVICE-542] Refresh FDC3 API docs #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-dinsdale
changed the title
tim-dinsdale
changed the title
pjbroadbent
reviewed
Jul 16, 2019
tomrobertsOF
approved these changes
Aug 9, 2019
added 3 commits
August 14, 2019 10:05
…into tim-dinsdale-dev/tim/SERVICE-543-1
pjbroadbent
reviewed
Aug 29, 2019
…into dev/tim/SERVICE-543-1
…le/fdc3-service into dev/tim/SERVICE-543-1
# Conflicts: # package-lock.json # src/client/context.ts # src/client/directory.ts # src/client/main.ts # src/demo/apps/ChartsApp.tsx # src/demo/apps/NewsApp.tsx # src/provider/controller/ResolverHandler.ts # src/provider/index.ts # src/provider/model/AppWindow.ts # src/provider/model/FinEnvironment.ts # test/demo/utils/fdc3RemoteExecution.ts # test/demo/utils/ofPuppeteer.ts # test/mocks.ts
… and adding details around changes since the original docs PR.
|
@pjbroadbent Taken another look, still outstanding comments |
…ions options as per FDC3 specs, replaced redundant Intent type with AppDirIntent.
…543-1 # Conflicts: # package-lock.json # src/client/context.ts # test/demo/raiseIntent/withoutTarget.inttest.ts # test/demo/utils/fdc3RemoteExecution.ts
…543-1 # Conflicts: # src/provider/model/AppWindow.ts # test/demo/raiseIntent/withTarget.inttest.ts # test/mocks.ts # test/provider/Model.unittest.ts
…ack'. Removed unused default intent definitions from provider. Removed duplicate Intent type definitions, added in earlier commit.
| * | ||
| * A context object is open for extension with any custom properties/metadata. | ||
| * General-purpose context type, as defined by [FDC3](https://fdc3.finos.org/docs/1.0/context-intro). | ||
| * A context object is a well-understood datum that is streamable between FDC3 participants. As a result |
There was a problem hiding this comment.
Is "streamable" the right term here?
bryangaleopenfin
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation