Enable different initial angle for circular slider. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue HamzaGhazouani#20: Setting the start position
|
thanks @iblagajic, I will review it this week-end |
|
👍 any updates? |
|
Would be good to get this in, otherwise we will Cherry Pick these changes into our fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #20: Setting the start position.
It is based on solution by @spaluchiewicz and this PR. I was unable to update the existing PR due to the access rights so I'm setting up a new one.
Commits are squashed to keep it clean, but @spaluchiewicz is kept as the coauthor. I hope this is fine.
In addition to setting the new position, I also tweaked the current implementation so that user can't swipe over the maximum and under the minimum value. Please let me know if you think it's appropriate or if we should make it a property that can be set. (Issue #10 )