feat(CLI): add a flag for Yarn Plug'n'Play #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
changed the title
Haroenv
commented
Nov 14, 2018
| `You are using Yarn ${ | ||
| yarnInfo.yarnVersion | ||
| } together with the --use-pnp flag, but Plug'n'Play is only supported starting from the 1.12 release.\n\n` + | ||
| `Please update to Yarn 1.12 or higher for a better, fully supported experience.\n` |
There was a problem hiding this comment.
will need to update this with the version that comes out of yarnpkg/yarn#6682
Haroenv
commented
Nov 14, 2018
| yarnVersion = execSync(`yarnpkg --version`) | ||
| .toString() | ||
| .trim() | ||
| hasMinYarnPnp = semver.gte(yarnVersion, `1.12.0`) |
There was a problem hiding this comment.
will have to update this after yarnpkg/yarn#6682 comes out (since Gatsby has a dependency, relay-compiler which is affected by this bug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is separated in multiple steps
The remaining step (5) is not implemented in this PR (because they touch too many internals of Gatsby):
./.cache./publicThese three steps rely heavily on transitive dependencies. For the first two you can fix it likely by making
@reach/router,lodash,prop-types,core-jseither not used until someone installs it, or using something likerequire.resolve. For eslint I couldn't dig deeper which part of Gatsby is relevant, and where the moduleseslint-plugin-import,eslint-plugin-flowtypeshould be listed as direct dependencies.