FIx failing docker compose #535
Conversation
There was a problem hiding this comment.
The updates look good @Tanvez! I rebuilt my local dev environment with the changes and the docker image built cleanly (pandas took forever to build, but other than that no issues).
Kudos for tracking down the source of the issues and bringing some of these outdated dependencies up-to-date. I left a few comments/suggestions below, but nothing blocking. 👍
Dockerfile
Outdated
| @@ -34,7 +36,7 @@ EXPOSE 8000 8080 | |||
|
|
|||
| FROM prod AS dev | |||
|
|
|||
| # Install python dev dependencies | |||
| # # Install python dev dependencies | |||
There was a problem hiding this comment.
nit: double hash (#) symbol
| @@ -8,9 +8,9 @@ RUN mkdir -p /app | |||
| WORKDIR /app | |||
|
|
|||
| # Install system dependencies and target node v14 | |||
| RUN curl -fsSL https://deb.nodesource.com/setup_14.x | bash - && \ | |||
| RUN curl -fsSL https://deb.nodesource.com/setup_21.x | bash - && \ | |||
There was a problem hiding this comment.
Note that NodeJS v20 is the LTS release and v21 is the current release, which has a much shorter support window. According to the release schedule, v21 will be EOL on June 1, 2024, so we may want to ensure we update to v22 (the next LTS release) when that's available later this Spring (or switch to the current LTS release v20).
There was a problem hiding this comment.
Thanks Artie! Will note that in the comments
hedera/requirements/base.in
Outdated
| pandas~=1.4.4 |
There was a problem hiding this comment.
Note that we could probably bump this to the latest 1.x release 1.5.3 without any issues. I briefly glanced at the Pandas Release Notes and didn't see any major incompatibilities from 1.4 to 1.5. Not sure about the jump to 2.0 though. AFAIK pandas is only being used in the import scripts.
There was a problem hiding this comment.
Sounds good will do!
| @@ -20,6 +20,8 @@ RUN pip install -r base.txt && \ | |||
|
|
|||
| # Install node dependencies | |||
| COPY ./package-lock.json ./package.json /app/ | |||
| # TODO: see if we can upgrade webpack/uglify to remedy NODE_OPTIONS | |||
| ARG NODE_OPTIONS=--openssl-legacy-provider | |||
There was a problem hiding this comment.
(For posterity) omitting the --openssl-legacy-provider node option results in an error message like this when doing an npm i:
ERROR in main-6d8044f3191ec0e46aaa.js from UglifyJs
19.84 Error: error:0308010C:digital envelope routines::unsupported
19.84 at new Hash (node:internal/crypto/hash:68:19)
19.84 at Object.createHash (node:crypto:138:10)
19.84 at /app/node_modules/uglifyjs-webpack-plugin/dist/index.js:186:40
19.84 at Array.forEach (<anonymous>)
19.84 at UglifyJsPlugin.optimizeFn (/app/node_modules/uglifyjs-webpack-plugin/dist/index.js:126:142)
19.84 at AsyncSeriesHook.eval [as callAsync] (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:21:1)
19.84 at AsyncSeriesHook.lazyCompileHook (/app/node_modules/tapable/lib/Hook.js:154:20)
19.84 at /app/node_modules/webpack/lib/Compilation.js:1409:36
19.84 at eval (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:11:1)
19.84 at /app/node_modules/copy-webpack-plugin/dist/index.js:598:9
19.84
19.84 ERROR in vendor-6d8044f3191ec0e46aaa.js from UglifyJs
19.84 Error: error:0308010C:digital envelope routines::unsupported
19.84 at new Hash (node:internal/crypto/hash:68:19)
The underlying issue seems to have to do with webpack v4 using an outdated hash function, which has been disallowed as of Node v17. The only way to allow it is to pass that legacy option. Long-term, we need to updgrade to webpack v5 which uses a newer hash function.
See also:
There was a problem hiding this comment.
Awesome! Thanks for adding context/reference to the --openssl-legacy-provider
| - name: Lint JavaScript | ||
| run: npm run lint | ||
| # - name: Lint JavaScript | ||
| # run: npm run lint |
There was a problem hiding this comment.
Is the intent to fix/restore the linting in a follow-up PR?
Edit: nevermind, I see you noted that in the PR description.
This PR fixes the failing docker compose by:
Removing the following and updating
package.json:babel-eslint:^10.1.0eslint:^7.9.0eslint-import-resolver-webpack:^0.12.2eslint-plugin-html:^6.1.0eslint-plugin-import:^2.22.0eslint-plugin-vue:^6.2.2Sassto version1.64.2Update Dockerfile with the following:
curl -fsSL https://deb.nodesource.com/setup_21.x | bash - && \ARG NODE_OPTIONS=--openssl-legacy-providerNote:
Not related to failing compose:
base.inpandas versionTo do
NODE_OPTIONS. Setup spike to look into webpack updates/migration